mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2024-12-11 03:21:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Cleanup: simplify DiveLocationLineEdit::showPopup()

Browse source 
DiveLocationLineEdit::showPopup() called the functions
	- fixPopupPosition()
	- proxy->invalidate()
	- proxy->sort(LocationInformationModel::NAME)
	- view->show()
All these calls are redundant, as they are already performed by
setTemporaryDiveSiteName(). Remove them.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2019-04-25 13:09:11 +02:00 committed by Dirk Hohndel
parent e76298a8a7
commit 4a61f155d3
1 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
desktop-widgets/locationinformation.cpp
View file

@ -575,13 +575,8 @@ void DiveLocationLineEdit::setCurrentDiveSite(struct dive *d)
void DiveLocationLineEdit::showPopup() void DiveLocationLineEdit::showPopup()
{ {
fixPopupPosition(); if (!view->isVisible())
if (!view->isVisible()) {
setTemporaryDiveSiteName(text()); setTemporaryDiveSiteName(text());
proxy->invalidate();
proxy->sort(LocationInformationModel::NAME);
view->show();
}
} }
DiveLocationLineEdit::DiveSiteType DiveLocationLineEdit::currDiveSiteType() const DiveLocationLineEdit::DiveSiteType DiveLocationLineEdit::currDiveSiteType() const