From 4b401eb2def0b90dd3958aa114d18621a14b7b9d Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Sat, 21 Sep 2019 14:30:04 +0200 Subject: [PATCH] Cleanup: return each dive site only once in selectedDiveSites() In TabDiveSite::selectedDiveSites(), the QItemSelectionModel:: selectedIndexes() function was used. Thus for every selected dive site 8 entries were added to the return-vector! Instead, use the QItemSelectionModel::selectedRows() function. Signed-off-by: Berthold Stoeger --- desktop-widgets/tab-widgets/TabDiveSite.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/desktop-widgets/tab-widgets/TabDiveSite.cpp b/desktop-widgets/tab-widgets/TabDiveSite.cpp index ee232b703..e9eee0a88 100644 --- a/desktop-widgets/tab-widgets/TabDiveSite.cpp +++ b/desktop-widgets/tab-widgets/TabDiveSite.cpp @@ -85,7 +85,7 @@ void TabDiveSite::on_filterText_textChanged(const QString &text) QVector TabDiveSite::selectedDiveSites() { - const QModelIndexList indexes = ui.diveSites->view()->selectionModel()->selectedIndexes(); + const QModelIndexList indexes = ui.diveSites->view()->selectionModel()->selectedRows(); QVector sites; sites.reserve(indexes.size()); for (const QModelIndex &idx: indexes) {