mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Mobile: insane hack to make map page work

Browse source 
This makes no sense and seems crazy. But it also seems to work,

For some reason with the current Kirigami version and Qt 5.13.1
selecting the map page makes the pageStack jump back to the previous
page right away. I cannot find what triggers this behavior.
Since I cannot fix the root cause, I am working around the bug. When we
select the map page we remember that fact and when a different page is
picked with the mapPage being the last page on the stack, we force the
page selection back to the map page. I can imagine countless ways in
which this could go horribly wrong - but right now I can't figure out a
better solution.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2019-10-06 18:48:35 -07:00
parent 8cd1abb7f7
commit 4e4fcda91c
1 changed files with 22 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
mobile-widgets/qml/main.qml
View file

@ -34,6 +34,7 @@ Kirigami.ApplicationWindow {
property bool firstChange: true
property int lastOrientation: undefined
property int colWidth: undefined
property bool hackToOpenMap: false
onNotificationTextChanged: {
if (notificationText != "") {
@ -615,12 +616,31 @@ if you have network connectivity and want to sync your data to cloud storage."),
}
pageStack.onCurrentItemChanged: {
// This is called whenever the user navigates using the breadcrumbs in the header
// This is called whenever the user navigates using the breadcrumbs in the header
// disable the left swipe to go back when on the map page
if (pageStack.currentItem === null) {
console.log("there's no current page")
} else {
// horrible, insane hack to make picking the mapPage work
// for some reason I cannot figure out, whenever the mapPage is selected
// we immediately switch back to the page before it - so force-prevent
// that undersired behavior
if (pageStack.currentItem.objectName === mapPage.objectName) {
// remember that we actively picked the mapPage
hackToOpenMap = true
} else if (pageStack.currentItem.objectName !== mapPage.objectName &&
pageStack.lastItem.objectName === mapPage.objectName &&
hackToOpenMap) {
// if we just picked the mapPage and are suddenly back on a different page
// force things back to the mapPage
pageStack.currentIndex = pageStack.contentItem.contentChildren.length - 1
hackToOpenMap = false
} else {
// if we picked a different page reset the mapPage hack
hackToOpenMap = false
}
// disable the left swipe to go back when on the map page
pageStack.interactive = pageStack.currentItem.objectName !== mapPage.objectName
// is there a better way to reload the map markers instead of doing that