mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Don't shadow object members like this

Browse source 
If you need to use this->error to distinguish the local variable from the
object membe that should be a hint that maybe you didn't pick the best
name for the local variable.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2014-02-12 05:51:25 -08:00
parent 11559f1704
commit 4f522d79d8
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
qt-ui/downloadfromdivecomputer.cpp
View file

@ -421,12 +421,12 @@ static QString str_error(const char *fmt, ...)
void DownloadThread::run() void DownloadThread::run()
{ {
const char *error; const char *errorText;
import_thread_cancelled = false; import_thread_cancelled = false;
if (!strcmp(data->vendor, "Uemis")) if (!strcmp(data->vendor, "Uemis"))
error = do_uemis_import(data->devname, data->force_download); errorText = do_uemis_import(data->devname, data->force_download);
else else
error = do_libdivecomputer_import(data); errorText = do_libdivecomputer_import(data);
if (error) if (errorText)
this->error = str_error(error, data->devname, data->vendor, data->product); error = str_error(errorText, data->devname, data->vendor, data->product);
} }