mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

profile: reimplement DivePercentageItem

Browse source 
The tissue percentages were realized as 16 independent polygons.
That didn't work at all with the new absolute scaling.

Reimplement the item and blast it onto a pixmap. Not only is
this artifact-free, it also should (hopefully) be quite a bit
more efficient than painting numerous lines.

In contrast to the old code, this does access the plot_info
structure directly instead of using the model. Not so much
for performance reason, but rather to make things more robust:
We have a strongly typed language. Why would we shoehorn data
through the weakly typed QVariant and mess with wierd
index-arithmetics. Makes no sense to me. Qt-model have to
be used for interfacing with Qt. They are terrible for
intra-application data transfer.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2021-08-29 22:13:26 +02:00 • committed by Dirk Hohndel
parent 24cf6709e3
commit 505e4e47eb
10 changed files with 177 additions and 89 deletions
Download patch file Download diff file Expand all files Collapse all files

23
profile-widget/divepercentageitem.h Normal file
View file

@ -0,0 +1,23 @@
#ifndef DIVEPERCENTAGEITEM_H
#define DIVEPERCENTAGEITEM_H
#include <QGraphicsPixmapItem>
struct dive;
struct divecomputer;
struct plot_info;
class DivePlotDataModel;
class DiveCartesianAxis;
class DivePercentageItem : public QGraphicsPixmapItem {
public:
DivePercentageItem(const DiveCartesianAxis &hAxis, const DiveCartesianAxis &vAxis, double dpr);
void replot(const dive *d, const divecomputer *dc, const plot_info &pi);
private:
const DiveCartesianAxis &hAxis;
const DiveCartesianAxis &vAxis;
int hDataColumn;
double dpr;
};
#endif