mobile cleanup: unduplicate code and do not loop over dives (2)

See e6e1473e6. Exact same commit but here for the
list of buddies.

Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>

mobile-widgets/qml/DiveDetails.qml

@@ -18,7 +18,6 @@ Kirigami.Page {
 	property alias watertemp: detailsEdit.watertempText
 	property alias buddyIndex: detailsEdit.buddyIndex
 	property alias buddyText: detailsEdit.buddyText
-	property alias buddyModel: detailsEdit.buddyModel
 	property alias divemasterIndex: detailsEdit.divemasterIndex
 	property alias divemasterText: detailsEdit.divemasterText
 	property alias divemasterModel: detailsEdit.divemasterModel
@@ -240,7 +239,7 @@ Kirigami.Page {
 		if (currentItem.modelData.dive.buddy.indexOf(",") > 0) {
 			buddyText = currentItem.modelData.dive.buddy;
 		} else {
-			buddyIndex = currentItem.modelData.dive.buddyList.indexOf(currentItem.modelData.dive.buddy)
+			buddyIndex = manager.buddyList.indexOf(currentItem.modelData.dive.buddy)
 		}
 		divemasterIndex = currentItem.modelData.dive.divemasterList.indexOf(currentItem.modelData.dive.divemaster)
 		notes = currentItem.modelData.dive.notes

mobile-widgets/qml/DiveDetailsEdit.qml

@@ -236,8 +236,7 @@ Item {
 			}
 			HintsTextEdit {
 				id: buddyBox
-				model: diveDetailsListView.currentItem && diveDetailsListView.currentItem.modelData !== null ?
-					diveDetailsListView.currentItem.modelData.dive.buddyList : null
+				model: manager.buddyList
 				inputMethodHints: Qt.ImhNoPredictiveText
 				Layout.fillWidth: true
 			}

mobile-widgets/qml/main.qml

@@ -81,7 +81,7 @@ Kirigami.ApplicationWindow {
 		detailsWindow.date = manager.getDate(detailsWindow.dive_id)
 		detailsWindow.airtemp = ""
 		detailsWindow.watertemp = ""
-		detailsWindow.buddyModel = manager.buddyInit
+		detailsWindow.buddyModel = manager.buddyList
 		detailsWindow.buddyIndex = -1
 		detailsWindow.buddyText = ""
 		detailsWindow.depth = ""