mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix uninitialised variable read

Browse source 
Found by Dr. Memory, run by Lubomir:
Error #48: UNINITIALIZED READ: reading register al
 # 0 StarWidget::mouseReleaseEvent()                        [qt-ui/starwidget.cpp:29]

Signed-off-by: Thiago Macieira <thiago@macieira.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Thiago Macieira 2013-11-30 09:18:01 -08:00 • committed by Dirk Hohndel
parent 22e0323d6a
commit 58d37e0200
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
qt-ui/starwidget.cpp
View file

@ -63,7 +63,8 @@ void StarWidget::setCurrentStars(int value)
StarWidget::StarWidget(QWidget* parent, Qt::WindowFlags f): StarWidget::StarWidget(QWidget* parent, Qt::WindowFlags f):
QWidget(parent, f), QWidget(parent, f),
current(0) current(0),
readOnly(false)
{ {
if (!activeStar) { if (!activeStar) {
activeStar = new QPixmap(); activeStar = new QPixmap();

3
qt-ui/starwidget.h
View file

@ -30,10 +30,11 @@ protected:
private: private:
int current; int current;
bool readOnly;
static QPixmap* activeStar; static QPixmap* activeStar;
static QPixmap* inactiveStar; static QPixmap* inactiveStar;
QPixmap grayImage(QPixmap *coloredImg); QPixmap grayImage(QPixmap *coloredImg);
bool readOnly;
}; };
#endif // STARWIDGET_H #endif // STARWIDGET_H