mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Remove cloud_background_sync preferences option

Browse source 
The preferences flag cloud_background_sync used to be used heavily in
the mobile code, but is not used there anymore. Now, it is accessed
only in one place, but does not do what it actually says: If it is off,
the remote storage is not synced on save (but will be synced on next
load).

Syncing on save can also be prevented by unchecking the "Cloud online"
menu checkbox. Since the latter seems more logical and general
(support for non-cloud remote git repositories), remove the cloud_background_sync
option.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2018-01-03 18:03:28 +01:00 • committed by Dirk Hohndel
parent b3901aa8f9
commit 59526e948a
9 changed files with 1 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

17
core/subsurface-qt/SettingsObjectWrapper.cpp
View file

@ -983,11 +983,6 @@ short CloudStorageSettings::verificationStatus() const
return prefs.cloud_verification_status;
}
bool CloudStorageSettings::backgroundSync() const
{
return prefs.cloud_background_sync;
}
QString CloudStorageSettings::userId() const
{
return QString(prefs.userid);
@ -1081,17 +1076,6 @@ void CloudStorageSettings::setVerificationStatus(short value)
emit verificationStatusChanged(value);
}
void CloudStorageSettings::setBackgroundSync(bool value)
{
if (value == prefs.cloud_background_sync)
return;
QSettings s;
s.beginGroup(group);
s.setValue("cloud_background_sync", value);
prefs.cloud_background_sync = value;
emit backgroundSyncChanged(value);
}
void CloudStorageSettings::setSaveUserIdLocal(bool value)
{
//TODO: this is not saved on disk?
@ -2300,7 +2284,6 @@ void SettingsObjectWrapper::load()
GET_TXT("password", cloud_storage_password);
}
GET_INT("cloud_verification_status", cloud_verification_status);
GET_BOOL("cloud_background_sync", cloud_background_sync);
GET_BOOL("git_local_only", git_local_only);
// creating the git url here is simply a convenience when C code wants