mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

selection: move test for programmatical selection changes to widget

Browse source 
The DiveListView widget has to differentiate between programmatical
und user-initiated selection changes. It did so by using the
DiveListNotifier::inCommand() flag.

However,
1) There is only one point of entry for such selection changes,
   viz. the MultiFilterSortModel::selectionChanged() signal
2) This signal is not only emitted in command-context.
   Another source is for example dive-map selection changes.

Therefore, move the programmatical-selection-change status down
to the widget and set/reset it in the diveSelectionChanged() slot.
This makes "select all visible dive sites" somewhat faster. Sadly,
not as much as expected.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2020-04-26 18:44:59 +02:00 • committed by Dirk Hohndel
parent aaecc6e98e
commit 5d49da5d6b
2 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
desktop-widgets/divelistview.h
View file

@ -86,6 +86,7 @@ private:
void contextMenuEvent(QContextMenuEvent *event) override;
void currentChanged(const QModelIndex &current, const QModelIndex &previous) override;
QNetworkAccessManager manager;
bool programmaticalSelectionChange;
};
#endif // DIVELISTVIEW_H