mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

More strict filter for URL handling in dive notes

Browse source 
Applie a more strict filter to URL handling in dive notes:
The URL needs to have:
- Scheme like "http:" or "mailto:"
- Host name like "www.test.de" or path like "/pathtosomewhere/"

Otherwise strings like "OTU:" or "Runtime:" are treated as URL.

Signed-off-by: Stefan Fuchs <sfuchs@gmx.de>
This commit is contained in:
Stefan Fuchs 2017-04-18 23:41:55 +02:00 • committed by Dirk Hohndel
parent c257144bab
commit 5e67a932cf
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
desktop-widgets/simplewidgets.cpp
View file

@ -704,7 +704,7 @@ void TextHyperlinkEventFilter::handleUrlTooltip(const QString &urlStr, const QPo
bool TextHyperlinkEventFilter::stringMeetsOurUrlRequirements(const QString &maybeUrlStr) bool TextHyperlinkEventFilter::stringMeetsOurUrlRequirements(const QString &maybeUrlStr)
{ {
QUrl url(maybeUrlStr, QUrl::StrictMode); QUrl url(maybeUrlStr, QUrl::StrictMode);
return url.isValid() && (!url.scheme().isEmpty()); return url.isValid() && (!url.scheme().isEmpty()) && ((!url.authority().isEmpty()) || (!url.path().isEmpty()));
} }
QString TextHyperlinkEventFilter::tryToFormulateUrl(QTextCursor *cursor) QString TextHyperlinkEventFilter::tryToFormulateUrl(QTextCursor *cursor)