mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2024-11-30 22:20:21 +00:00
Code Issues Projects Releases Packages Wiki Activity

qPref: don't compare doubles for equality

Browse source 
This is a much safer way to do this.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2018-09-22 18:01:16 -07:00 committed by Jan Mulder
parent 617019bc6b
commit 619289074b
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
core/settings/qPrefPrivate.cpp
View file

@ -1,5 +1,6 @@
// SPDX-License-Identifier: GPL-2.0
#include "qPrefPrivate.h"
#include "core/subsurface-string.h"
#include <QSettings>
@ -22,7 +23,13 @@ void qPrefPrivate::propSetValue(const QString &key, const QVariant &value, const
// Having it as a local variable is light weight, because it is an
// interface class.
QSettings s;
if (value != defaultValue)
bool isDefault = false;
if (value.isValid() && value.type() == QVariant::Double)
isDefault = IS_FP_SAME(value.toDouble(), defaultValue.toDouble());
else
isDefault = (value == defaultValue);
if (!isDefault)
s.setValue(key, value);
else
s.remove(key);