mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

cleanup: don't call uiLanguage() in qPref::loadSync()

Browse source 
uiLanguage() initializes the language fields from the preferences
values. It is unclear why this function is called in qPref::loadSync()
*before* the fields are loaded from disk. It can only initialize to
the default values anyway. After qPref::loadSync() uiLanguage()
is called again so that everything can be initialized with the
correct perferences values.

Remove the first call. If things break, let's fix them in a sensible
way.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2020-03-22 16:01:34 +01:00 • committed by Dirk Hohndel
parent 2db7d5cc23
commit 621d00d891
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
core/settings/qPref.cpp
View file

@ -23,9 +23,6 @@
void qPref::loadSync(bool doSync)
{
if (!doSync)
uiLanguage(NULL);
// the following calls, ensures qPref* is instanciated, registred and
// that properties are loaded
qPrefCloudStorage::loadSync(doSync);