mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

statistics: make selection keyboard modifiers more general

Browse source 
Up to now, we passed a "shiftPressed" flag to the individual
selection functions. To be more general replace by a struct
with "shift" and "ctrl" flags.

While doing this:
1) Move the struct into a new statsselection file for better
   encapsulation.
2) Change shift to control in the scatter series, since individual
   selection of items is usually done with control, not shift.
   Shift usually means "select range".

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2021-02-08 17:07:37 +01:00 • committed by Dirk Hohndel
parent 21b8cded56
commit 64b82b16a2
16 changed files with 47 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

6
stats/statsseries.h
View file

@ -4,6 +4,8 @@
#ifndef STATS_SERIES_H
#define STATS_SERIES_H
#include "statsselection.h"
#include <vector>
#include <QPointF>
@ -20,10 +22,10 @@ public:
virtual bool hover(QPointF pos) = 0; // Called on mouse movement. Return true if an item of this series is highlighted.
virtual void unhighlight() = 0; // Unhighlight any highlighted item.
// Returns true if an item was under the mouse.
virtual bool selectItemsUnderMouse(const QPointF &pos, bool shiftPressed) = 0;
virtual bool selectItemsUnderMouse(const QPointF &pos, SelectionModifier modifier) = 0;
virtual bool supportsLassoSelection() const;
// Needs only be defined if supportsLassoSelection() returns true.
virtual void selectItemsInRect(const QRectF &rect, bool shiftPressed, const std::vector<dive *> &oldSelection);
virtual void selectItemsInRect(const QRectF &rect, SelectionModifier modifier, const std::vector<dive *> &oldSelection);
virtual void divesSelected(const QVector<dive *> &dives) = 0;
protected: