mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Mobile: fix editing dive site

Browse source 
Commit 68961a169e made it impossible
to edit a dive site on mobile if a dive-site was already set: If
divesite was non-null, no actions were taken. Remove the conditional.

Reported-by: Miika Turkia <miika.turkia@gmail.com>
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2018-12-28 10:22:10 +01:00 • committed by Dirk Hohndel
parent 1e1d7513b2
commit 691d44dfd1
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
mobile-widgets/qmlmanager.cpp
View file

@ -887,11 +887,9 @@ bool QMLManager::checkLocation(DiveObjectHelper *myDive, struct dive *d, QString
qDebug() << "checkLocation" << location << "gps" << gps << "dive had" << myDive->location() << "gps" << myDive->gas(); qDebug() << "checkLocation" << location << "gps" << gps << "dive had" << myDive->location() << "gps" << myDive->gas();
if (myDive->location() != location) { if (myDive->location() != location) {
diveChanged = true; diveChanged = true;
if (!ds) ds = get_dive_site_by_name(qPrintable(location));
ds = get_dive_site_by_name(qPrintable(location)); if (!ds && !location.isEmpty())
if (!ds && !location.isEmpty()) {
ds = create_dive_site(qPrintable(location), d->when); ds = create_dive_site(qPrintable(location), d->when);
}
d->dive_site = ds; d->dive_site = ds;
} }
// now make sure that the GPS coordinates match - if the user changed the name but not // now make sure that the GPS coordinates match - if the user changed the name but not