mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Rework foreach for a faster iteration.

Browse source 
The old code used a QString instead of a const QString&, wich
mean that each foreach step the string was copied.
added a break on the if-found-true to stop the foreach, since
we already found it.

Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Tomaz Canabrava 2013-12-24 09:38:35 -02:00 • committed by Dirk Hohndel
parent 03a01efdcb
commit 6925d13aa4
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
qt-ui/globe.cpp
View file

@ -30,12 +30,15 @@ GlobeGPS::GlobeGPS(QWidget* parent) : MarbleWidget(parent), loadedDives(0), edit
// if not, check if they are in a known location // if not, check if they are in a known location
MapThemeManager mtm; MapThemeManager mtm;
QStringList list = mtm.mapThemeIds(); QStringList list = mtm.mapThemeIds();
QString theme, subsurfaceDataPath; QString subsurfaceDataPath;
QDir marble; QDir marble;
bool foundGoogleMap = false; bool foundGoogleMap = false;
Q_FOREACH(theme, list) Q_FOREACH(const QString& theme, list){
if (theme == "earth/googlesat/googlesat.dgml") if (theme == "earth/googlesat/googlesat.dgml"){
foundGoogleMap = true; foundGoogleMap = true;
break;
}
}
if (!foundGoogleMap) { if (!foundGoogleMap) {
subsurfaceDataPath = getSubsurfaceDataPath("marbledata"); subsurfaceDataPath = getSubsurfaceDataPath("marbledata");
if (subsurfaceDataPath != "") { if (subsurfaceDataPath != "") {