Cleanups to core/color.[c|hpp]

A number of small cleanups to the color-table:

1) Make the profile_color map of static linkage - it is not
used outside of this file.

2) Remove the third color, which originally was planned for
printing. It was not accessed anywhere.

3) Replace QVector<QColor> by std::array<QColor, 2>. Using a
reference-counted, copy-on-write, dynamic container for static
data seems like overkill. std::array<QColor, 2> has exactly the
same run-time impact as QColor[2], but allows for assignment.

4) Use brace-initialization and remove the unneeded COLOR macro.

5) Remove the fill_profile_color function. Simply use static
initialization.

6) Move #includes from .h to .cpp file.

7) Remove text_render_options(_t), which were not used anywhere.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2018-07-17 20:12:29 +02:00 committed by Lubomir I. Ivanov
parent 2c6b1a99af
commit 6d72871942
4 changed files with 64 additions and 78 deletions

View file

@ -83,7 +83,6 @@ int main(int argc, char **argv)
else
default_prefs.units = IMPERIAL_units;
copy_prefs(&default_prefs, &prefs);
fill_profile_color();
fill_computer_list();
parse_xml_init();