mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-01-19 14:25:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

desktop: select dives at once

Browse source 
The old code would call QItemSelectionModel::select() once for every dive.
Instead collect the selection in a QItemSelection and only call
QItemSelectionModel::select() once. This makes selecting multiple dives
significantly faster.

The loop also expanded the trips with selections. This has now to be
done in an extra loop.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2020-04-26 21:21:44 +02:00 • committed by Dirk Hohndel
parent 4f438d1e32
commit 6e83135fba
1 changed files with 17 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
desktop-widgets/divelistview.cpp
View file

@ -208,16 +208,24 @@ void DiveListView::diveSelectionChanged(const QVector<QModelIndex> &indices)
programmaticalSelectionChange = true;
clearSelection();
QItemSelectionModel *s = selectionModel();
for (const QModelIndex &index: indices) {
s->select(index, QItemSelectionModel::Rows | QItemSelectionModel::Select);
QItemSelection selection;
for (const QModelIndex &index: indices)
selection.select(index, index); // Is there a faster way to do this?
selectionModel()->select(selection, QItemSelectionModel::Rows | QItemSelectionModel::Select);
// If an item of a not-yet expanded trip is selected, expand the trip.
if (index.parent().isValid() && !isExpanded(index.parent())) {
setAnimated(false);
expand(index.parent());
setAnimated(true);
// Expand all unexpanded trips
std::vector<int> affectedTrips;
for (const QModelIndex &index: indices) {
if (!index.parent().isValid())
continue;
int row = index.parent().row();
if (std::find(affectedTrips.begin(), affectedTrips.end(), row) == affectedTrips.end())
affectedTrips.push_back(row);
}
MultiFilterSortModel *m = MultiFilterSortModel::instance();
for (int row: affectedTrips) {
QModelIndex idx = m->index(row, 0);
expand(idx);
}
selectionChangeDone();