mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Simplify tripflags: remove tripflag_names[]

Browse source 
This removes the tripflag name array, since it's not actually useful.
The only information we ever save in the XML file is whether a dive is
explicitly not supposed to ever be grouped with a trip ("NOTRIP"), and
everything else is implicit.

I'm going to simplify the trip flags further (possibly removing it
entirely - like I did for dive trips already), and don't like having to
maintain the tripflag_names[] array logic.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Linus Torvalds 2012-11-26 14:52:07 -08:00 • committed by Dirk Hohndel
parent 3f197336aa
commit 6fe52ee19e
4 changed files with 4 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

5
divelist.c
View file

@ -43,11 +43,6 @@ static struct DiveList dive_list;
dive_trip_t *dive_trip_list;
gboolean autogroup = FALSE;
/* this duplicate assignment of "INTRIP" causes the save_xml code
* to convert an ASSIGNED_TRIP (which is temporary in memory) to
* a statically assigned trip (INTRIP) in file */
const char *tripflag_names[NUM_TRIPFLAGS] = { "TF_NONE", "NOTRIP", "INTRIP", "INTRIP" };
/*
* The dive list has the dive data in both string format (for showing)
* and in "raw" format (for sorting purposes)