mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

tests: fix TestQPrefEquipment

Browse source 
When we actually change the value, the argument to the changed signal
should be true, not false.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2019-12-28 10:00:46 -08:00
parent 18fe7b8e9a
commit 7046bb4f82
1 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tests/testqPrefEquipment.cpp
View file

@ -93,12 +93,18 @@ void TestQPrefEquipment::test_oldPreferences()
void TestQPrefEquipment::test_signals() void TestQPrefEquipment::test_signals()
{ {
qPrefEquipment::set_default_cylinder("signal test");
QSignalSpy spy1(qPrefEquipment::instance(), &qPrefEquipment::default_cylinderChanged); QSignalSpy spy1(qPrefEquipment::instance(), &qPrefEquipment::default_cylinderChanged);
QSignalSpy spy2(qPrefEquipment::instance(), &qPrefEquipment::display_unused_tanksChanged); QSignalSpy spy2(qPrefEquipment::instance(), &qPrefEquipment::display_unused_tanksChanged);
qPrefEquipment::set_default_cylinder("new base21"); // set default cylinder to same value it already had
qPrefEquipment::set_default_cylinder("signal test");
QCOMPARE(spy1.count(), 0);
// change default cylinder to different value
qPrefEquipment::set_default_cylinder("different value");
QCOMPARE(spy1.count(), 1); QCOMPARE(spy1.count(), 1);
QVERIFY(spy1.takeFirst().at(0).toBool() == false); QVERIFY(spy1.takeFirst().at(0).toBool() == true);
prefs.display_unused_tanks = true; prefs.display_unused_tanks = true;
qPrefEquipment::set_display_unused_tanks(false); qPrefEquipment::set_display_unused_tanks(false);