mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-01 03:43:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

Map: don't call exitEditMode() in MapWidget::reload()

Browse source 
On reload of the map, the map exits edit mode. Sounds logical
at first, but the whole map-mode code is very unpredictable.

What happened was that when switching from the dive site table
to dive site edit mode, the code would enter map edit mode first.
Then, the dive site tab got its hide-signal, which would reset the
filter. This would reload the map and thus exit mode. Hence the user
can't drag the flag on the map.

Partially fixes #2076

Reported-by: Doug Junkins <junkins@foghead.com>
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2019-04-29 07:34:48 +02:00 • committed by Dirk Hohndel
parent 144de49ad4
commit 743f217620
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
desktop-widgets/mapwidget.cpp
View file

@ -86,7 +86,6 @@ void MapWidget::repopulateLabels()
void MapWidget::reload()
{
CHECK_IS_READY_RETURN_VOID();
m_mapHelper->exitEditMode();
if (!skipReload)
m_mapHelper->reloadMapLocations();
}