mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

cleanup: less than operators shall not use equal

Browse source 
See also commit c032006d91. Compare functions passed
to sort functions need to compare for less-than and not
less-or-equal.

Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
This commit is contained in:
Jan Mulder 2017-12-29 19:29:23 +01:00 • committed by Dirk Hohndel
parent f74308bed4
commit 75142b0a63
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
desktop-widgets/preferences/preferencesdialog.cpp
View file

@ -90,7 +90,7 @@ void PreferencesDialog::buttonClicked(QAbstractButton* btn)
bool abstractpreferenceswidget_lessthan(AbstractPreferencesWidget *p1, AbstractPreferencesWidget *p2) bool abstractpreferenceswidget_lessthan(AbstractPreferencesWidget *p1, AbstractPreferencesWidget *p2)
{ {
return p1->positionHeight() <= p2->positionHeight(); return p1->positionHeight() < p2->positionHeight();
} }
void PreferencesDialog::addPreferencePage(AbstractPreferencesWidget *page) void PreferencesDialog::addPreferencePage(AbstractPreferencesWidget *page)

2
qt-models/diveplannermodel.cpp
View file

@ -659,7 +659,7 @@ void DivePlannerPointsModel::setStartTime(const QTime &t)
bool divePointsLessThan(const divedatapoint &p1, const divedatapoint &p2) bool divePointsLessThan(const divedatapoint &p1, const divedatapoint &p2)
{ {
return p1.time <= p2.time; return p1.time < p2.time;
} }
int DivePlannerPointsModel::lastEnteredPoint() int DivePlannerPointsModel::lastEnteredPoint()