mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

profile: fix logic in keyDeleteAction()

Browse source 
The code took care to not delete planner-points when no
points are selected. However, it assumed that all selected
objects are planner-points. But then it checked whether
the selected object actually is a planner-point. So which
is it?

Remove the outter check for an empty selection. This makes
things more logical and more robust, should there ever
be other objects that can be selected.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2021-01-26 18:35:48 +01:00 • committed by Dirk Hohndel
parent 1ec0790d50
commit 752724aa1e
1 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
profile-widget/profilewidget2.cpp
View file

@ -1910,17 +1910,15 @@ void ProfileWidget2::keyDeleteAction()
if ((currentState != ADD && currentState != PLAN) || !plannerModel) if ((currentState != ADD && currentState != PLAN) || !plannerModel)
return; return;
int selCount = scene()->selectedItems().count(); QVector<int> selectedIndices;
if (selCount) { Q_FOREACH (QGraphicsItem *i, scene()->selectedItems()) {
QVector<int> selectedIndices; if (DiveHandler *handler = qgraphicsitem_cast<DiveHandler *>(i)) {
Q_FOREACH (QGraphicsItem *i, scene()->selectedItems()) { selectedIndices.push_back(handleIndex(handler));
if (DiveHandler *handler = qgraphicsitem_cast<DiveHandler *>(i)) { handler->hide();
selectedIndices.push_back(handleIndex(handler));
handler->hide();
}
} }
plannerModel->removeSelectedPoints(selectedIndices);
} }
if (!selectedIndices.isEmpty())
plannerModel->removeSelectedPoints(selectedIndices);
} }
void ProfileWidget2::keyEscAction() void ProfileWidget2::keyEscAction()