From 7598e2fce724ba42d1b9be4dbd7adfa169473e28 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Fri, 11 Jan 2019 06:53:22 +0200 Subject: [PATCH] Download: don't refresh display if thread finished After the downloading finished, the mainwindow-display is reset via a signal. This is probably an artifact of old times, when downloading was done into the main dive-list. Nowadays, this seems to make little sense, as the main dive-list is not changed by download. Remove the signal. Signed-off-by: Berthold Stoeger --- desktop-widgets/downloadfromdivecomputer.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/desktop-widgets/downloadfromdivecomputer.cpp b/desktop-widgets/downloadfromdivecomputer.cpp index 3c70d8686..ffa005c89 100644 --- a/desktop-widgets/downloadfromdivecomputer.cpp +++ b/desktop-widgets/downloadfromdivecomputer.cpp @@ -72,10 +72,6 @@ DownloadFromDCWidget::DownloadFromDCWidget(QWidget *parent, Qt::WindowFlags f) : connect(&thread, SIGNAL(finished()), this, SLOT(onDownloadThreadFinished()), Qt::QueuedConnection); - //TODO: Don't call mainwindow. - MainWindow *w = MainWindow::instance(); - connect(&thread, SIGNAL(finished()), w, SLOT(refreshDisplay())); - if (!qPrefDiveComputer::vendor().isEmpty()) { ui.vendor->setCurrentIndex(ui.vendor->findText(qPrefDiveComputer::vendor())); productModel.setStringList(productList[qPrefDiveComputer::vendor()]);