mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Change taglist_get_tagstring to support 'unlimited' tag list size

Browse source 
Previous taglist_get_tagstring signature/implementation did not allow
handling of cases where inputted buffer could not contain all tags.
New implementation allocates buffer based on pre-computed size allowing to
insert all tags in the returned string.

Added get_taglist_string in qthelper to handle conversion to QString
Added TestTagList with tests for taglist_get_tagstring

Signed-off-by: Jeremie Guichard <djebrest@gmail.com>
This commit is contained in:
Jeremie Guichard 2018-04-09 10:09:34 +02:00 • committed by Dirk Hohndel
parent f1830cd44e
commit 7753352e62
10 changed files with 140 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

7
qt-models/divetripmodel.cpp
View file

@ -422,12 +422,7 @@ QString DiveItem::displayWeightWithUnit() const
QString DiveItem::displayTags() const
{
struct dive *dive = get_dive_by_uniq_id(diveId);
if (!dive->tag_list)
return QString();
char buf[1024];
taglist_get_tagstring(dive->tag_list, buf, 1024);
return QString(buf);
return get_taglist_string(dive->tag_list);
}
int DiveItem::weight() const