mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

cleanup: make members of ThemeInterface non-static

Browse source 
We have a singleton class ThemeInterface, which means that it
is global and exists only once. It's members are static, i.e.
also global. A message from the department of redundancy department?
In any case, that makes no sense. Let's just make these members
local to the class.

I would even rip out the whole singleton thing, since the object
is not accessed anywhere outside from QML. Let's keep it for now.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2020-03-30 21:01:54 +02:00 • committed by Dirk Hohndel
parent 7f2eaba574
commit 79bf243ec0
3 changed files with 44 additions and 65 deletions
Download patch file Download diff file Expand all files Collapse all files

2
subsurface-helper.cpp
View file

@ -199,7 +199,7 @@ void register_qml_types(QQmlEngine *engine)
// Register qml interface classes
QMLInterface::setup(ct);
themeInterface::setup(ct);
themeInterface::instance()->setup(ct);
}
REGISTER_TYPE(QMLManager, "QMLManager");