mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

debug: try to capture changes that don't invalidate git cache

Browse source 
At least in those cases where we are sending a divesChanged signal we can
easily check if the cache was properly invalidated. Of course this won't help
in cases where we don't notify the dive list about changes, either.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2020-02-17 17:16:11 -08:00
parent 45d37fd51b
commit 7d9e907681
5 changed files with 34 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

15
mobile-widgets/qmlmanager.cpp
View file

@ -264,6 +264,11 @@ QMLManager::QMLManager() : m_locationServiceEnabled(false),
what.tags = true;
what.cylinders = true;
what.weights = true;
// monitor when dives changed - but only in verbose mode
// careful - changing verbose at runtime isn't enough (of course that could be added if we want it)
if (verbose)
connect(&diveListNotifier, &DiveListNotifier::divesChanged, this, &QMLManager::divesChanged);
}
void QMLManager::applicationStateChanged(Qt::ApplicationState state)
@ -2189,3 +2194,13 @@ void QMLManager::setOldStatus(const qPrefCloudStorage::cloud_status value)
emit oldStatusChanged();
}
}
void QMLManager::divesChanged(const QVector<dive *> &dives, DiveField field)
{
Q_UNUSED(field)
for (struct dive *d: dives) {
qDebug() << "dive #" << d->number << "changed, cache is" << (dive_cache_is_valid(d) ? "valid" : "invalidated");
// a brute force way to deal with that would of course be to call
// invalidate_dive_cache(d);
}
}

2
mobile-widgets/qmlmanager.h
View file

@ -17,6 +17,7 @@
#include "qt-models/completionmodels.h"
#include "qt-models/divelocationmodel.h"
#include "core/settings/qPrefCloudStorage.h"
#include "core/subsurface-qt/divelistnotifier.h"
#define NOCLOUD_LOCALSTORAGE format_string("%s/cloudstorage/localrepo[master]", system_default_directory())
@ -226,6 +227,7 @@ public slots:
void hasLocationSourceChanged();
void btRescan();
void showDownloadPage(QString deviceString);
void divesChanged(const QVector<dive *> &dives, DiveField field);
private:
BuddyCompletionModel buddyModel;