mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Mobile: pass QString as value to registerError()

Browse source 
registerError() may be called from a different thread context. Passing
the message as a const-reference may lead to a dangling reference.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2018-03-12 10:55:26 +01:00 • committed by Lubomir I. Ivanov
parent cdba35530b
commit 7da214a8c4
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
mobile-widgets/qmlmanager.cpp
View file

@ -89,7 +89,7 @@ extern "C" int gitProgressCB(const char *text)
return 0; return 0;
} }
void QMLManager::registerError(const QString &error) void QMLManager::registerError(QString error)
{ {
appendTextToLog(error); appendTextToLog(error);
if (!m_lastError.isEmpty()) if (!m_lastError.isEmpty())

2
mobile-widgets/qmlmanager.h
View file

@ -61,7 +61,7 @@ public:
}; };
static QMLManager *instance(); static QMLManager *instance();
Q_INVOKABLE void registerError(const QString &error); Q_INVOKABLE void registerError(QString error);
QString consumeError(); QString consumeError();
QString cloudUserName() const; QString cloudUserName() const;