mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

core: replace dive_site::dives by an std::vector<>

Browse source 
Since this is now in C++, we don't have to use our crazy
TABLE_* macros.

This contains a logic change: the dives associated to a
dive site are now unsorted.

The old code was subtly buggy: dives were added in a sorted
manner, but when the dive was edited the list was not
resorted. Very unlikely that this leads to a serious
problem, still not good.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2024-05-04 14:41:04 +02:00 • committed by bstoeger
parent 3f8b4604be
commit 801b5d50b2
12 changed files with 39 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

4
qt-models/maplocationmodel.cpp
View file

@ -120,13 +120,13 @@ const QVector<dive_site *> &MapLocationModel::selectedDs() const
static bool hasVisibleDive(const dive_site *ds)
{
return std::any_of(&ds->dives.dives[0], &ds->dives.dives[ds->dives.nr],
return std::any_of(ds->dives.begin(), ds->dives.end(),
[] (const dive *d) { return !d->hidden_by_filter; });
}
static bool hasSelectedDive(const dive_site *ds)
{
return std::any_of(&ds->dives.dives[0], &ds->dives.dives[ds->dives.nr],
return std::any_of(ds->dives.begin(), ds->dives.end(),
[] (const dive *d) { return d->selected; });
}