mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Undo: make dive-import undoable

Browse source 
On desktop, replace all add_imported_dives() calls by a new undo-command.
This was rather straight forward, as all the preparation work was done
in previous commits.

By using an undo-command, a full UI-reset can be avoided, making the UI
react smoother.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2018-12-23 23:45:12 +01:00 • committed by Dirk Hohndel
parent 0249e12589
commit 82c47bdd79
9 changed files with 122 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

19
desktop-widgets/downloadfromdivecomputer.cpp
View file

@ -521,25 +521,12 @@ void DownloadFromDCWidget::on_ok_clicked()
}
if (table->nr > 0) {
MainWindow::instance()->diveList->unselectDives();
// remember the last downloaded dive (on most dive computers this will be the chronologically
// first new dive) and select it again after processing all the dives
int uniqId = table->dives[table->nr - 1]->id;
add_imported_dives(table, trips, preferDownloaded(), true, false);
Command::clear();
// after add_imported_dives does any merging or resorting needed, we need
// to recreate the model for the dive list so we can select the newest dive
MainWindow::instance()->recreateDiveList();
int idx = get_idx_by_uniq_id(uniqId);
// this shouldn't be necessary - but there are reports that somehow existing dives stay selected
// (but not visible as selected)
MainWindow::instance()->diveList->unselectDives();
MainWindow::instance()->diveList->selectDive(idx, true);
auto data = thread.data();
Command::importDives(table, trips, preferDownloaded(), true, false, data->devName());
}
if (ostcFirmwareCheck && currentState == DONE) {
if (ostcFirmwareCheck && currentState == DONE)
ostcFirmwareCheck->checkLatest(this, thread.data()->internalData());
}
accept();
}