mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Dive site: use own copy of taxonomy in dive-site-edit widget

Browse source 
The dive-site-edit widget uses a copy of the to-be-edited site
to compare with old values. Generally, this seems overkill
(the original dive-site can be used for such a comparison).
But one place where it can't simply be removed is the taxonomy,
because the widget needs a place to store the unsaved data.

Change the code to use an explicit taxonomy structure instead
of the one provided in the copy. This should ultimately allow
removal of the latter.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2018-10-13 11:52:59 +02:00 • committed by Dirk Hohndel
parent 5d3967ce84
commit 8815f77ea0
8 changed files with 44 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

2
desktop-widgets/tab-widgets/maintab.cpp
View file

@ -418,7 +418,7 @@ void MainTab::updateDiveInfo(bool clear)
ds = get_dive_site_by_uuid(displayed_dive.dive_site_uuid);
if (ds) {
ui.location->setCurrentDiveSiteUuid(ds->uuid);
ui.locationTags->setText(constructLocationTags(ds, true));
ui.locationTags->setText(constructLocationTags(&ds->taxonomy, true));
} else {
ui.location->clear();
ui.locationTags->clear();