mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

desktop: don't update notes field when executing command

Browse source 
User report: when switching focus between windows, the
cursor position gets lost. This is due to a note-edit
command being fired, which then overwrites the notes tab.

To prevent this, don't update the notes field when placing
a command. Moreover, generally don't update the dive
selection when placing a command as that also rewrites all
the values.

Should this be extended to other fields?

Fixes #3365

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2022-02-14 21:59:49 +01:00 • committed by Dirk Hohndel
parent 1b8f3a06ec
commit 889827aadb
4 changed files with 6 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

3
commands/command_edit.cpp
View file

@ -156,7 +156,8 @@ void EditBase<T>::undo()
// Send signals.
DiveField id = fieldId();
emit diveListNotifier.divesChanged(stdToQt<dive *>(dives), id);
setSelection(selectedDives, current);
if (!placingCommand())
setSelection(selectedDives, current);
}
// We have to manually instantiate the constructors of the EditBase class,