mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Filter: constify doFilter() argument

Browse source 
Conceptually, the doFilter() functions shouldn't modify the dive
they test. Therefore, make the argument const. To do this, constify
the parameter of get_dive_location(), which likewise seems to be
the right thing to do.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2018-08-14 14:09:30 -04:00
parent fb47c15cd8
commit 8a394b9db4
4 changed files with 14 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

12
qt-models/filtermodels.h
View file

@ -7,10 +7,12 @@
#include <stdint.h>
#include <vector>
struct dive;
class FilterModelBase : public QStringListModel {
Q_OBJECT
public:
virtual bool doFilter(struct dive *d) const = 0;
virtual bool doFilter(const dive *d) const = 0;
void clearFilter();
void selectAll();
void invertSelection();
@ -34,7 +36,7 @@ class TagFilterModel : public FilterModelBase {
Q_OBJECT
public:
static TagFilterModel *instance();
bool doFilter(struct dive *d) const;
bool doFilter(const dive *d) const;
public
slots:
void repopulate();
@ -48,7 +50,7 @@ class BuddyFilterModel : public FilterModelBase {
Q_OBJECT
public:
static BuddyFilterModel *instance();
bool doFilter(struct dive *d) const;
bool doFilter(const dive *d) const;
public
slots:
void repopulate();
@ -62,7 +64,7 @@ class LocationFilterModel : public FilterModelBase {
Q_OBJECT
public:
static LocationFilterModel *instance();
bool doFilter(struct dive *d) const;
bool doFilter(const dive *d) const;
public
slots:
void repopulate();
@ -78,7 +80,7 @@ class SuitsFilterModel : public FilterModelBase {
Q_OBJECT
public:
static SuitsFilterModel *instance();
bool doFilter(struct dive *d) const;
bool doFilter(const dive *d) const;
public
slots:
void repopulate();