mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Misc: replace some FIXME comments

Browse source 
All these aren't actually things that need fixing, they are observations about
the code.

Given that LGTM.com reports FIXME comments as Alerts, let's change the ones
that aren't about things that need fixing to something more harmless.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2019-03-19 08:22:51 -07:00
parent c7bb67c5be
commit 8e43d2b8d2
4 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
core/configuredivecomputerthreads.cpp
View file

@ -1442,7 +1442,7 @@ static dc_status_t read_ostc_settings(dc_device_t *device, DeviceDetails *m_devi
unsigned char data[256] = {};
#ifdef DEBUG_OSTC_CF
// FIXME: how should we report settings not supported back?
// open question: how should we report settings not supported back?
unsigned char max_CF = 0;
#endif
rc = hw_ostc_device_eeprom_read(device, 0, data, sizeof(data));
@ -1829,7 +1829,7 @@ static dc_status_t write_ostc_settings(dc_device_t *device, DeviceDetails *m_dev
else if (gas5.type == 2)
data[33] = 5;
else
// FIXME: No gas was First?
// odd: No gas was First?
// Set gas 1 to first
data[33] = 1;
@ -1956,7 +1956,7 @@ static dc_status_t write_ostc_settings(dc_device_t *device, DeviceDetails *m_dev
else if (dil5.type == 2)
data[115] = 5;
else
// FIXME: No first diluent?
// odd: No first diluent?
// Set gas 1 to fist
data[115] = 1;
@ -2178,7 +2178,7 @@ void WriteSettingsThread::run()
}
break;
case DC_FAMILY_HW_OSTC3:
// FIXME: Is this the best way?
// Is this the best way?
if (m_deviceDetails->model == "OSTC 4")
rc = write_ostc4_settings(m_data->device, m_deviceDetails, DeviceThread::event_cb, this);
else

4
core/dive.c
View file

@ -1577,7 +1577,7 @@ static void simplify_dc_pressures(struct divecomputer *dc)
}
}
/* FIXME! sensor -> cylinder mapping? */
/* Do we need a sensor -> cylinder mapping? */
static void fixup_start_pressure(struct dive *dive, int idx, pressure_t p)
{
if (idx >= 0 && idx < MAX_CYLINDERS) {
@ -2366,7 +2366,7 @@ static int match_cylinder(const cylinder_t *cyl, const struct dive *dive, unsign
if (different_manual_pressures(cyl, target))
continue;
/* FIXME! Should we check sizes too? */
/* open question: Should we check sizes too? */
return i;
}
return -1;

2
core/profile.c
View file

@ -915,7 +915,7 @@ static void setup_gas_sensor_pressure(const struct dive *dive, const struct dive
/* calculate DECO STOP / TTS / NDL */
static void calculate_ndl_tts(struct deco_state *ds, const struct dive *dive, struct plot_data *entry, struct gasmix gasmix, double surface_pressure,enum divemode_t divemode)
{
/* FIXME: This should be configurable */
/* should this be configurable? */
/* ascent speed up to first deco stop */
const int ascent_s_per_step = 1;
const int ascent_s_per_deco_step = 1;

2
desktop-widgets/subsurfacewebservices.cpp
View file

@ -536,7 +536,7 @@ DivelogsDeWebServices::DivelogsDeWebServices(QWidget *parent, Qt::WindowFlags f)
multipart(NULL),
uploadMode(false)
{
//FIXME: DivelogDE user and pass should be on the prefs struct or something?
// should DivelogDE user and pass be stored in the prefs struct or something?
QSettings s;
ui.userID->setText(s.value("divelogde_user").toString());
ui.password->setText(s.value("divelogde_pass").toString());