mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

cleanup: pass location_t as value to divesite functions

Browse source 
These were passed as pointers, which makes no sense.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2024-05-12 22:30:15 +02:00 • committed by bstoeger
parent 858a0aecba
commit 90d5bab4e9
8 changed files with 16 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

8
core/divesite.cpp
View file

@ -41,9 +41,9 @@ dive_site *dive_site_table::get_by_gps(const location_t *loc) const
/* to avoid a bug where we have two dive sites with different name and the same GPS coordinates
* and first get the gps coordinates (reading a V2 file) and happen to get back "the other" name,
* this function allows us to verify if a very specific name/GPS combination already exists */
dive_site *dive_site_table::get_by_gps_and_name(const std::string &name, const location_t *loc) const
dive_site *dive_site_table::get_by_gps_and_name(const std::string &name, const location_t loc) const
{
return get_by_predicate(*this, [&name, loc](const auto &ds) { return ds->location == *loc &&
return get_by_predicate(*this, [&name, loc](const auto &ds) { return ds->location == loc &&
ds->name == name; });
}
@ -93,7 +93,7 @@ dive_site::dive_site(const std::string &name) : name(name)
{
}
dive_site::dive_site(const std::string &name, const location_t *loc) : name(name), location(*loc)
dive_site::dive_site(const std::string &name, const location_t loc) : name(name), location(loc)
{
}
@ -134,7 +134,7 @@ dive_site *dive_site_table::create(const std::string &name)
}
/* same as before, but with GPS data */
dive_site *dive_site_table::create(const std::string &name, const location_t *loc)
dive_site *dive_site_table::create(const std::string &name, const location_t loc)
{
return register_site(std::make_unique<dive_site>(name, loc)).ptr;
}