mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

First step towards grabbing keys and handling them ourselves

Browse source 
This commit steals the cursor up and down keys away from gtk so regardless
where gtk thinks the focus may be, we can still use the keys to change
between dives.

In the current UI design where all editing happens in separate windows
this works as expected, as we only grab the keys for the main window. If
we manage to re-enable in-place editing then we need to make sure that
this doesn't cause problems (as gtk uses up/down for the ability to change
drop down selections in combo boxes or values in spin buttons. So we must
make sure that we stop stealing these keys once we start editing something
(in which case simply switching to the next/prev dive wouldn't be a good
thing, anyway).

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2013-01-01 08:22:46 -08:00
parent d720e133d8
commit 91ca0d2cf6
3 changed files with 120 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

19
gtk-gui.c
View file

@ -5,6 +5,7 @@
*/
#include <libintl.h>
#include <glib/gi18n.h>
#include <gdk/gdkkeysyms.h>
#include <stdio.h>
#include <string.h>
#include <stdlib.h>
@ -1130,6 +1131,21 @@ static void switch_page(GtkNotebook *notebook, gint arg1, gpointer user_data)
repaint_dive();
}
static gboolean on_key_press(GtkWidget *w, GdkEventKey *event, GtkWidget *divelist)
{
if (event->type != GDK_KEY_PRESS)
return FALSE;
switch (event->keyval) {
case GDK_KEY_Up:
select_prev_dive();
return TRUE;
case GDK_KEY_Down:
select_next_dive();
return TRUE;
}
return FALSE;
}
void init_ui(int *argcp, char ***argvp)
{
GtkWidget *win;
@ -1325,6 +1341,9 @@ void init_ui(int *argcp, char ***argvp)
nb_page = total_stats_widget();
gtk_notebook_append_page(GTK_NOTEBOOK(notebook), nb_page, gtk_label_new(_("Stats")));
/* handle some keys globally (to deal with gtk focus issues) */
g_signal_connect (G_OBJECT (win), "key_press_event", G_CALLBACK (on_key_press), dive_list);
gtk_widget_set_app_paintable(win, TRUE);
gtk_widget_show_all(win);