mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

cleanup: more Coverity silencing

Browse source 
Mostly irrelevant std::move() stuff of copy-on-write Qt objects,
a few real bugs, a timestamp_t downconversion and some codingsyle
adaptation.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2024-01-16 17:39:19 +01:00 • committed by Dirk Hohndel
parent 35ff6eea35
commit 91e4fb4769
27 changed files with 47 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

6
desktop-widgets/mainwindow.cpp
View file

@ -1354,9 +1354,8 @@ void MainWindow::on_actionImportDiveLog_triggered()
logFiles.append(fn);
}
if (logFiles.size()) {
if (logFiles.size())
importFiles(logFiles);
}
if (csvFiles.size()) {
DiveLogImportDialog diveLogImport(std::move(csvFiles), this);
@ -1553,9 +1552,8 @@ void MainWindow::hideProgressBar()
}
}
void MainWindow::divesChanged(const QVector<dive *> &dives, DiveField field)
void MainWindow::divesChanged(const QVector<dive *> &dives, DiveField)
{
Q_UNUSED(field)
for (struct dive *d: dives) {
qDebug() << "dive #" << d->number << "changed, cache is" << (dive_cache_is_valid(d) ? "valid" : "invalidated");
// a brute force way to deal with that would of course be to call