mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

cleanup: more Coverity silencing

Browse source 
Mostly irrelevant std::move() stuff of copy-on-write Qt objects,
a few real bugs, a timestamp_t downconversion and some codingsyle
adaptation.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2024-01-16 17:39:19 +01:00 • committed by Dirk Hohndel
parent 35ff6eea35
commit 91e4fb4769
27 changed files with 47 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

6
stats/statsvariables.cpp
View file

@ -329,14 +329,14 @@ QString StatsVariable::nameWithUnit() const
{
QString s = name();
QString symb = unitSymbol();
return symb.isEmpty() ? s : QStringLiteral("%1 [%2]").arg(s, symb);
return symb.isEmpty() ? std::move(s) : QStringLiteral("%1 [%2]").arg(s, symb);
}
QString StatsVariable::nameWithBinnerUnit(const StatsBinner &binner) const
{
QString s = name();
QString symb = binner.unitSymbol();
return symb.isEmpty() ? s : QStringLiteral("%1 [%2]").arg(s, symb);
return symb.isEmpty() ? std::move(s) : QStringLiteral("%1 [%2]").arg(s, symb);
}
const StatsBinner *StatsVariable::getBinner(int idx) const
@ -551,7 +551,7 @@ std::vector<StatsBinValue<T>> bin_convert(const StatsVariable &variable, const S
T v = func(dives);
if (is_invalid_value(v) && (res.empty() || !fill_empty))
continue;
res.push_back({ std::move(bin), v });
res.push_back({ std::move(bin), std::move(v) });
}
if (res.empty())
return res;