mirror of
				https://github.com/subsurface/subsurface.git
				synced 2025-02-19 22:16:15 +00:00 
			
		
		
		
	models: update divesite-model when clearing/updating dive model
When the dive list is cleared or updated, the entries in the divesite-model become stale and therefore the divesite-model (with the actual name LocationInformationModel) also must be updated. This was done manually in some parts of the code and forgotten in others. Therefore, do it directly in the clear() and reset() function of the dive list-model. This might be a bit of a layering violation: why should one model call into another if they are not in parent/child relationship? However, this seems easier than introducing a global "reset dives" function that coordinates the models. Moreover, it does not appear 100% safe: if the clearing of the divesite model causes accesses to the divelist-model, they happen in the midst of a model reset and we had horrible bugs with that kind of things. However, I don't think that should happen. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
		
							parent
							
								
									9722f04e40
								
							
						
					
					
						commit
						9310d72943
					
				
					 3 changed files with 2 additions and 2 deletions
				
			
		|  | @ -517,7 +517,6 @@ void MainTab::reload() | |||
| 	buddyModel.updateModel(); | ||||
| 	diveMasterModel.updateModel(); | ||||
| 	tagModel.updateModel(); | ||||
| 	LocationInformationModel::instance()->update(); | ||||
| } | ||||
| 
 | ||||
| void MainTab::refreshDisplayedDiveSite() | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue