mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Cleanup: remove bogus mark_divelist_changed() calls

Browse source 
The parsers / downloaders parse into a separate table and do
not directly change the divelist. Therefore, they shouldn't
call mark_divelist_changed().

Likewise split_dive_at() doesn't modify the dive list and
therefore shouldn't call this function.

Calling the function has the unwanted side-effect that undoing
the change will not clear the *-symbol in the title of the
main window.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2019-07-17 15:58:26 +02:00 • committed by Dirk Hohndel
parent 726d08c2f7
commit 94521c9958
6 changed files with 0 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
core/dive.c
View file

@ -3195,8 +3195,6 @@ static int split_dive_at(const struct dive *dive, int a, int b, struct dive **ou
d2->number = 0;
}
mark_divelist_changed(true);
*out1 = d1;
*out2 = d2;
return nr;