mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Make all current written tests pass

Browse source 
Fixes a couple of issues with the tests.
Also, a type in prefs.h is "short" while it's actually
a boolean, this made me write the wrong testcase for this.

Fixed this by setting the Qt wrapper to bool, but I didn't
changed the c implementation because I tought I could break
something.

Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Tomaz Canabrava 2016-10-15 20:26:34 +02:00 • committed by Dirk Hohndel
parent c1fbc70d83
commit 9c4b0170bf
3 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

8
core/subsurface-qt/SettingsObjectWrapper.h
View file

@ -288,7 +288,7 @@ class ProxySettings : public QObject {
Q_PROPERTY(int type READ type WRITE setType NOTIFY typeChanged)
Q_PROPERTY(QString host READ host WRITE setHost NOTIFY hostChanged)
Q_PROPERTY(int port READ port WRITE setPort NOTIFY portChanged)
Q_PROPERTY(short auth READ auth WRITE setAuth NOTIFY authChanged)
Q_PROPERTY(bool auth READ auth WRITE setAuth NOTIFY authChanged)
Q_PROPERTY(QString user READ user WRITE setUser NOTIFY userChanged)
Q_PROPERTY(QString pass READ pass WRITE setPass NOTIFY passChanged)
@ -297,7 +297,7 @@ public:
int type() const;
QString host() const;
int port() const;
short auth() const;
bool auth() const;
QString user() const;
QString pass() const;
@ -305,7 +305,7 @@ public slots:
void setType(int value);
void setHost(const QString& value);
void setPort(int value);
void setAuth(short value);
void setAuth(bool value);
void setUser(const QString& value);
void setPass(const QString& value);
@ -313,7 +313,7 @@ signals:
void typeChanged(int value);
void hostChanged(const QString& value);
void portChanged(int value);
void authChanged(short value);
void authChanged(bool value);
void userChanged(const QString& value);
void passChanged(const QString& value);
private: