mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Trivial: un-static function-local buffer

Browse source 
In visit_on_node() in core/parse-xml.c the name is extracted into
a static buffer. There seems to be no need for this being static,
as the name is only passed to the entry() function which (hopefully)
does not store a reference to the name anywhere.

If it does, this would need a *big* *fat* comment.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2018-09-21 13:23:36 +02:00 • committed by Dirk Hohndel
parent d2b8088cd8
commit 9c8deef477
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
core/parse-xml.c
View file

@ -1451,7 +1451,7 @@ static const char *nodename(xmlNode *node, char *buf, int len)
static bool visit_one_node(xmlNode *node)
{
xmlChar *content;
static char buffer[MAXNAME];
char buffer[MAXNAME];
const char *name;
content = node->content;