mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

mobile/export: don't allow file based exports on Android

Browse source 
There is no native file dialog, access to the file system is highly restricted
and will be much more so in Android 11. Let's not even start with this.

This should never have been merged as it was.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2020-02-15 11:45:19 -08:00
parent 0178f0c7e7
commit 9e36968881
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
mobile-widgets/qml/Export.qml
View file

@ -114,6 +114,10 @@ Kirigami.ScrollablePage {
}
}
// given that there is no native file dialog on Android and that access to
// the file system is increasingly restrictive in future versions, file based
// export really doesn't make sense on Android
ColumnLayout {
width: parent.width
spacing: 1
@ -123,6 +127,7 @@ Kirigami.ScrollablePage {
RadioButton {
Layout.fillWidth: true
text: qsTr("Export Subsurface XML")
visible: Qt.platform.os !== "android"
checked: true
exclusiveGroup: radioGroup
onClicked: {
@ -133,6 +138,7 @@ Kirigami.ScrollablePage {
RadioButton {
Layout.fillWidth: true
text: qsTr("Export Subsurface dive sites XML")
visible: Qt.platform.os !== "android"
exclusiveGroup: radioGroup
onClicked: {
selectedExport = ExportType.EX_DIVE_SITES_XML
@ -142,6 +148,7 @@ Kirigami.ScrollablePage {
RadioButton {
Layout.fillWidth: true
text: qsTr("Export UDDF")
visible: Qt.platform.os !== "android"
exclusiveGroup: radioGroup
onClicked: {
selectedExport = ExportType.EX_UDDF
@ -199,7 +206,7 @@ Kirigami.ScrollablePage {
textPassword.visible = false
fieldPassword.visible = false
uploadDialog.open()
} else {
} else if (Qt.platform.os !== "android") {
saveAsDialog.open()
}
}