From 9e3d85f0e2e974c22eb1e464c0667c28f48ff44c Mon Sep 17 00:00:00 2001 From: jan Iversen Date: Fri, 27 Dec 2019 13:26:05 +0100 Subject: [PATCH] mobile-widgets: correct faulty connect. 1) add comment line (signal to signal) 2) correct spelling error in comment 3) correct connect Signed-off-by: Jan Iversen --- mobile-widgets/qmlmanager.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mobile-widgets/qmlmanager.cpp b/mobile-widgets/qmlmanager.cpp index abb01f67a..801df3de5 100644 --- a/mobile-widgets/qmlmanager.cpp +++ b/mobile-widgets/qmlmanager.cpp @@ -162,6 +162,7 @@ QMLManager::QMLManager() : m_locationServiceEnabled(false), connect(qobject_cast(QApplication::instance()), &QApplication::applicationStateChanged, this, &QMLManager::applicationStateChanged); // make upload signals available in QML + // Remark: signal - signal connect connect(uploadDiveLogsDE::instance(), &uploadDiveLogsDE::uploadFinish, this, &QMLManager::uploadFinish); connect(uploadDiveLogsDE::instance(), &uploadDiveLogsDE::uploadProgress, @@ -170,10 +171,10 @@ QMLManager::QMLManager() : m_locationServiceEnabled(false), this, &QMLManager::uploadProgress); // uploadDiveShare::uploadFinish() is defined with 3 parameters, - // whereas QMLManager::uploadFinish() is defined with 2 paramters, + // whereas QMLManager::uploadFinish() is defined with 2 parameters, // Solution add a slot as landing zone. - connect(uploadDiveShare::instance(), SIGNAL(uploadDiveShare::uploadFinish(bool, const QString &, const QByteArray &)), - this, SLOT(uploadFinishSlot(bool, const QString &, const QByteArray &))); + connect(uploadDiveShare::instance(), &uploadDiveShare::uploadFinish, + this, &QMLManager::uploadFinishSlot); #if defined(Q_OS_ANDROID) || defined(Q_OS_IOS) #if defined(Q_OS_ANDROID)