From 9f9853fc4495cc70db260a0b8bca5aa13e00ce6c Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Thu, 14 Apr 2016 10:53:06 -0700 Subject: [PATCH] Hack to work around issue in current Kirigami master Commit 339411cca69b in Kirigami master tries to reparent the OverlaySheet to the page that it is related to. Unfortunately the heuristic used there to find the right object assumes that every page has a contentItem property, which our DiveDetails page doesn't have. As a hack to work around this issue (until this is fixed upstream in Kirigami) we simply create such a property. This commit should be reverted once Kirigami upstream has been fixed. Signed-off-by: Dirk Hohndel --- mobile-widgets/qml/DiveDetails.qml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mobile-widgets/qml/DiveDetails.qml b/mobile-widgets/qml/DiveDetails.qml index 262f2042c..c9d123d07 100644 --- a/mobile-widgets/qml/DiveDetails.qml +++ b/mobile-widgets/qml/DiveDetails.qml @@ -28,6 +28,8 @@ Kirigami.Page { property alias gasmix: detailsEdit.gasmixText property int updateCurrentIdx: manager.updateSelectedDive + property bool contentItem: true // HACK to work around Kirigami issue - remove once that's addressed upstream + title: diveDetailsListView.currentItem ? diveDetailsListView.currentItem.modelData.dive.location : "Dive details" state: "view"