mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Test dives for duplicate names and conflicting GPS

Browse source 
The conflicting GPS is somewhat artificial. Since the GPS gets parsed
first in our syntax, the different GPS location would create a new dive
site and we'd end up with two dive sites of the same name with different
coordinates. By having a location tag with just the name and no
coordinates we make sure that this gets identified with the existing dive
site and THEN add the GPS coordinates in the second location tag.

This would never happen in a XML file created by Subsurface, but it does a
good job in testing the different code paths.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2015-02-14 18:13:35 -08:00
parent 57d5a40e95
commit a081fb34e0
1 changed files with 28 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

28
dives/test50.xml Normal file
View file

@ -0,0 +1,28 @@
<divelog program='subsurface' version='2'>
<settings>
</settings>
<dives>
<dive number='1' date='2015-1-1' time='10:00:00' duration='30:00 min'>
<location gps='7.132557 134.224213'>Blue Corner</location>
<notes>This dive is at the Blue Corner with the correct coordinates</notes>
<divecomputer model='Heinrichs Weikamp OSTC 3' deviceid='01234567' diveid='76543210'>
<depth max='30.00 m' mean='17.72 m' />
</divecomputer>
</dive>
<dive number='2' date='2015-1-2' time='10:00:00' duration='30:00 min'>
<location gps='7.132557 134.224213'>Yellow Corner</location>
<notes>This dive is at the Yellow Corner but with the coordinates of Blue Corner</notes>
<divecomputer model='Heinrichs Weikamp OSTC 3' deviceid='01234567' diveid='76543210'>
<depth max='30.00 m' mean='17.72 m' />
</divecomputer>
</dive>
<dive number='1' date='2015-1-3' time='10:00:00' duration='30:00 min'>
<location>Blue Corner</location>
<location gps='7.132557 34.224213'>Blue Corner</location>
<notes>This dive is at the Blue Corner but the coordinates are wrong. In order to trigger the right behavior here I had to mess with the XML file; it contains two sets of location tags, the first just with the name and only the second then adds the gps coordinates. Otherwise the gps coordinates get parsed first and create a new dive site and we don't even notice the duplicate name.</notes>
<divecomputer model='Heinrichs Weikamp OSTC 3' deviceid='01234567' diveid='76543210'>
<depth max='30.00 m' mean='17.72 m' />
</divecomputer>
</dive>
</dives>
</divelog>