mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Desktop: Use DiveImportedModel::deleteDeselected()

Browse source 
In DownloadFromDCWidget::on_ok_clicked() deselected dives were
directly deleted from the dive table, leaving DiveImportedModel
in an inconsistent state. Use the function in DiveImportedModel
instead. This also removes code duplication.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2019-09-22 18:55:45 +02:00 • committed by Dirk Hohndel
parent 30b384cebd
commit a24b1a4027
1 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
desktop-widgets/downloadfromdivecomputer.cpp
View file

@ -529,14 +529,7 @@ void DownloadFromDCWidget::on_ok_clicked()
struct dive_site_table *sites = diveImportedModel->thread.sites(); struct dive_site_table *sites = diveImportedModel->thread.sites();
// delete non-selected dives // delete non-selected dives
int total = table->nr; diveImportedModel->deleteDeselected();
int j = 0;
for (int i = 0; i < total; i++) {
if (diveImportedModel->data(diveImportedModel->index(i, 0), Qt::CheckStateRole) == Qt::Checked)
j++;
else
delete_dive_from_table(diveImportedModel->thread.table(), j);
}
if (table->nr > 0) { if (table->nr > 0) {
auto data = diveImportedModel->thread.data(); auto data = diveImportedModel->thread.data();