From a31a9d0911ebde77f4dac8582ad3466af2338508 Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Sun, 17 Mar 2019 11:43:06 -0700 Subject: [PATCH] Core: remove variable name conflict Having a char parameter with the same name as a global char * variable is confusing. Found via LGTM.com Signed-off-by: Dirk Hohndel --- core/datatrak.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/datatrak.c b/core/datatrak.c index 51db84606..74486af0d 100644 --- a/core/datatrak.c +++ b/core/datatrak.c @@ -32,12 +32,12 @@ static unsigned long four_bytes_to_long(unsigned char x, unsigned char y, unsign return ((long)x << 24) + ((long)y << 16) + ((long)z << 8) + (long)t; } -static unsigned char *byte_to_bits(unsigned char byte) +static unsigned char *byte_to_bits(unsigned char byte_value) { unsigned char i, *bits = (unsigned char *)malloc(8); for (i = 0; i < 8; i++) - bits[i] = byte & (1 << i); + bits[i] = byte_value & (1 << i); return bits; }