mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

QML UI: do not crash on selecting dive computers

Browse source 
For reasons unknown to me, the DCDeviceData instance was freed way too early,
and used afterwards, obviously resulting in a SIGSEGV. This commit creates
the DCDeviceData as a direct child of the QMLManager instance, ensuring
it does not get freed prematurely.

Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Jan Mulder 2017-06-08 13:38:52 +02:00 • committed by Dirk Hohndel
parent 22e40063f1
commit a7288cc912
3 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
core/downloadfromdcthread.cpp
View file

@ -16,11 +16,11 @@ static QString str_error(const char *fmt, ...)
return str;
}
DownloadThread::DownloadThread() : m_data(new DCDeviceData())
DownloadThread::DownloadThread()
{
m_data = DCDeviceData::instance();
}
void DownloadThread::run()
{
auto internalData = m_data->internalData();