From a8f45406bdad1bd10854d609b326b5567ef92353 Mon Sep 17 00:00:00 2001 From: Jan Mulder Date: Wed, 3 Oct 2018 09:54:49 +0200 Subject: [PATCH] QML UI, consistency: add text attribute for all actions Something I only see on mobile-on-desktop, so at this point in time not very relevant to the device apps. When hovering on the action button, a toast message shows a hint box. These where empty in some cases. So, just give the actions a text attribute where it was missing. Signed-off-by: Jan Mulder --- mobile-widgets/qml/DiveDetails.qml | 1 + mobile-widgets/qml/DiveList.qml | 2 ++ 2 files changed, 3 insertions(+) diff --git a/mobile-widgets/qml/DiveDetails.qml b/mobile-widgets/qml/DiveDetails.qml index e2c70fb98..aaa12dc7a 100644 --- a/mobile-widgets/qml/DiveDetails.qml +++ b/mobile-widgets/qml/DiveDetails.qml @@ -189,6 +189,7 @@ Kirigami.Page { name: state !== "view" ? ":/icons/document-save.svg" : ":/icons/document-edit.svg" color: subsurfaceTheme.primaryColor } + text: state !== "view" ? qsTr("Save edits") : qsTr("Edit dive") onTriggered: { manager.appendTextToLog("save/edit button triggered") if (state === "edit" || state === "add") { diff --git a/mobile-widgets/qml/DiveList.qml b/mobile-widgets/qml/DiveList.qml index d676549b4..b353b135c 100644 --- a/mobile-widgets/qml/DiveList.qml +++ b/mobile-widgets/qml/DiveList.qml @@ -404,6 +404,7 @@ Kirigami.ScrollablePage { name: ":/icons/downloadDC" color: subsurfaceTheme.primaryColor } + text: qsTr("Download dives") onTriggered: { showDownloadPage() } @@ -413,6 +414,7 @@ Kirigami.ScrollablePage { icon { name: ":/icons/list-add" } + text: qsTr("Add dive") onTriggered: { startAddDive() }