mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

cleanup: make various functions in DiveListView private

Browse source 
Outside callers had no business calling these functions.
Especially some functions that were simply there to override
default DiveListView behavior. Mark these as overridden.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2020-04-25 21:07:38 +02:00 • committed by Dirk Hohndel
parent b8e7a600d2
commit aaecc6e98e
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
desktop-widgets/divelistview.h
View file

@ -23,14 +23,8 @@ class DiveListView : public QTreeView {
public: public:
DiveListView(QWidget *parent = 0); DiveListView(QWidget *parent = 0);
~DiveListView(); ~DiveListView();
void mouseDoubleClickEvent(QMouseEvent * event);
void selectionChanged(const QItemSelection &selected, const QItemSelection &deselected);
void currentChanged(const QModelIndex &current, const QModelIndex &previous);
void setSortOrder(int i, Qt::SortOrder order); // Call to set sort order void setSortOrder(int i, Qt::SortOrder order); // Call to set sort order
void reload(); // Call to reload model data void reload(); // Call to reload model data
bool eventFilter(QObject *, QEvent *);
void unselectDives();
void contextMenuEvent(QContextMenuEvent *event);
QList<dive_trip *> selectedTrips(); QList<dive_trip *> selectedTrips();
static QString lastUsedImageDir(); static QString lastUsedImageDir();
static void updateLastUsedImageDir(const QString &s); static void updateLastUsedImageDir(const QString &s);
@ -63,9 +57,11 @@ slots:
void tripChanged(dive_trip *trip, TripField); void tripChanged(dive_trip *trip, TripField);
private: private:
void setSelection(const QRect &rect, QItemSelectionModel::SelectionFlags flags) override; void setSelection(const QRect &rect, QItemSelectionModel::SelectionFlags flags) override;
void unselectDives();
void mouseReleaseEvent(QMouseEvent *event) override; void mouseReleaseEvent(QMouseEvent *event) override;
void keyPressEvent(QKeyEvent *event) override; void keyPressEvent(QKeyEvent *event) override;
void selectAll() override; void selectAll() override;
void selectionChanged(const QItemSelection &selected, const QItemSelection &deselected);
void selectionChangeDone(); void selectionChangeDone();
DiveTripModelBase::Layout currentLayout; DiveTripModelBase::Layout currentLayout;
QModelIndex contextMenuIndex; QModelIndex contextMenuIndex;
@ -85,6 +81,10 @@ private:
void addToTrip(int delta); void addToTrip(int delta);
void matchImagesToDives(QStringList fileNames); void matchImagesToDives(QStringList fileNames);
void loadImageFromURL(QUrl url); void loadImageFromURL(QUrl url);
bool eventFilter(QObject *, QEvent *) override;
void mouseDoubleClickEvent(QMouseEvent *event) override;
void contextMenuEvent(QContextMenuEvent *event) override;
void currentChanged(const QModelIndex &current, const QModelIndex &previous) override;
QNetworkAccessManager manager; QNetworkAccessManager manager;
}; };